Bug 161137 - Inserting autotext converts style into direct formatting
Summary: Inserting autotext converts style into direct formatting
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:24.8.0 target:24.2.4
Keywords:
Depends on:
Blocks: AutoText
  Show dependency treegraph
 
Reported: 2024-05-16 16:54 UTC by Gabor Kelemen (allotropia)
Modified: 2024-05-18 20:30 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from LO 3.3 (15.35 KB, application/vnd.oasis.opendocument.text)
2024-05-16 16:54 UTC, Gabor Kelemen (allotropia)
Details
The document before autotext insertion, with Style Inspector (152.83 KB, image/png)
2024-05-16 16:55 UTC, Gabor Kelemen (allotropia)
Details
After using autotext, "Numbering 1" also becomes paragraph direct formatting (208.13 KB, image/png)
2024-05-16 17:18 UTC, Gabor Kelemen (allotropia)
Details
Image of the indentation produced by the autotext after it is inserted and the style inspector (337.73 KB, image/png)
2024-05-16 21:56 UTC, breadsathwik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-05-16 16:54:36 UTC
Created attachment 194152 [details]
Example file from LO 3.3

When autotext is inserted into the attached example file, the numbering style attached to the paragraph style is applied as direct formatting to the new text, overriding paragraph style settings.

1. Open attached file
2. Go to the end of the document, observe the last paragraph has a -1 cm left indent, making it show up on the left margin
3. Type "lorem" and press F3
-> the inserted paragraphs are numbered, but do not have the -1 cm left indent. They have the default of the numbering.

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 2f791732ebb722973cd2f5ca344725b955aef387
CPU threads: 14; OS: Windows 10 X86_64 (10.0 build 19045); UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

and back to LO 3.3.
Comment 1 Gabor Kelemen (allotropia) 2024-05-16 16:55:48 UTC
Created attachment 194153 [details]
The document before autotext insertion, with Style Inspector
Comment 2 Gabor Kelemen (allotropia) 2024-05-16 17:18:03 UTC
Created attachment 194154 [details]
After using autotext, "Numbering 1" also becomes paragraph direct formatting
Comment 3 breadsathwik 2024-05-16 21:53:37 UTC
Hi, I could not reproduce this issue. The auto text formats into the left margin by -1 cm as intended.

I used:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e939685f9c6918830bd3097062790bfccbce937e
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Maybe someone else can reproduce it.
Comment 4 breadsathwik 2024-05-16 21:56:03 UTC
Created attachment 194160 [details]
Image of the indentation produced by the autotext after it is inserted and the style inspector
Comment 5 Commit Notification 2024-05-17 17:24:07 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7698f386413e514a4478a1af69a8a3be93dfecab

tdf#161137 sw: fix AutoText or Paste overriding paragraph indents

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-05-17 17:25:10 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2bcaa374ea418cd81f9dbf62cd7e896f5977992a

tdf#161137 sw: AutoText or Paste should copy paragraph indents for lists

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Michael Stahl (allotropia) 2024-05-17 17:28:58 UTC
should be fixed on master
Comment 8 Commit Notification 2024-05-18 20:30:28 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/2e2ea78e585d469373c038aa12c5b99909a018c8

tdf#161137 sw: fix AutoText or Paste overriding paragraph indents

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-05-18 20:30:31 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/b01d89eaf473870281f6ecbdeb12aa3fcd79f9bb

tdf#161137 sw: AutoText or Paste should copy paragraph indents for lists

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.